[L0][OpenCL] Emulate Fill with copy when patternSize is not a power of 2 #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 14.82% 12.51% -2.32%
==========================================
Files 250 239 -11
Lines 36220 35949 -271
Branches 4094 4076 -18
==========================================
- Hits 5369 4498 -871
- Misses 30800 31447 +647
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
keyradical
force-pushed
the
memsetLargePatternL0
branch
from
59cdd8a to
293b670
Compare
keyradical
changed the title
keyradical
force-pushed
the
memsetLargePatternL0
branch
from
3887dfd to
ac0274f
Compare
Contributor
Author
|
friendly ping @oneapi-src/unified-runtime-level-zero-write @oneapi-src/unified-runtime-opencl-write, could I get a review on this please? |
aarongreig
approved these changes
Mar 26, 2024
keyradical
force-pushed
the
memsetLargePatternL0
branch
2 times, most recently
from
a6f5dfe to
617d8ad
Compare
kbenzie
added
level-zero
keyradical
force-pushed
the
memsetLargePatternL0
branch
from
617d8ad to
38037e9
Compare
keyradical
force-pushed
the
memsetLargePatternL0
branch
2 times, most recently
from
9de2356 to
e4a8d29
Compare
kbenzie
force-pushed
the
memsetLargePatternL0
branch
from
41ab8b4 to
2727e8a
Compare
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
May 2, 2024
…f 2 (#12912) oneapi-src/unified-runtime#1412 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
May 2, 2024
This PR changes the `queue.fill()` implementation to make use of the native functions for a specific backend. It also unifies that implementation with the one for memset, since it is just an 8-bit subset operation of fill. In the CUDA case, both memset and fill are currently calling `urEnqueueUSMFill` which depending on the size of the filling pattern calls either `cuMemsetD8Async`, `cuMemsetD16Async`, `cuMemsetD32Async` or `commonMemSetLargePattern`. Before this patch memset was using the same thing, just beforehand setting patternSize always to 1 byte which resulted in calling `cuMemsetD8Async`. In other backends, the behaviour is analogous. The fill method was just invoking a `parallel_for` to fill the memory with the pattern which was making this operation quite slow. This PR depends on: - oneapi-src/unified-runtime#1395 - oneapi-src/unified-runtime#1412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LevelZero changes:
enqueueMemFillHelperto allow calling it with pattern sizes which are not powers of 2. In those cases filling is emulated with copying.OpenCL changes:
isPowerOf2to the USM fill functionThose changes are necessary for the PR: intel/llvm#12702 which refactors
queue.fill()to make use of theurEnqueueUSMFill.intel/llvm CI: intel/llvm#12912