[OpenCL] Modify fill emulation to work for patterns which are not powers of 2 #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
reviewed
May 14, 2024
kbenzie
approved these changes
May 14, 2024
keyradical
added
ready to merge
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1412 which added the
isPowerOf2condition to the OpenCL fill function. This is correct sinceclEnqueueMemFillINTEL_fnonly accepts such patterns.What was not correct was the later logic for emulating filling on the host and copying it to the destination ptr. It assumed that the pattern is greater than 128 bytes but after adding the above
isPowerOf2condition, it could also execute for smaller patterns which are simply not powers of 2.So this PR fixes my introduced bugs, intel/llvm CI: intel/llvm#13779