Command-buffer immediate command-list CTS fix #1960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered in oneapi-src#1951 (comment) there is an issue running the command-buffer CTS tests on L0 with command-lists enabled. After investigating, this was because the CTS tests we're not using the output event parameter to command-buffer enqueue. In the L0 adapter code a path for registering an event with the queue to waiting on the workload was guarded by this event being set. Therefore `urQueueFinish` was not working as expected, as the queue was not aware of this work to wait on. Fixed by always registering the work to wait on with the queue, and miss out on propagation of the created event when user doesn't pass an output event, rather than not creating it at all.
github-actions
bot
added
level-zero
fabiomestre
approved these changes
Aug 12, 2024
nrspruit
approved these changes
Aug 12, 2024
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix!
omarahmed1111
pushed a commit
to reble/llvm
that referenced
this pull request
Aug 13, 2024
Tests UR PR oneapi-src/unified-runtime#1960 for fixing a UR CTS bug in the L0 adapter for command-buffers.
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Aug 13, 2024
Tests UR PR oneapi-src/unified-runtime#1960 for fixing a UR CTS bug in the L0 adapter for command-buffers.
53 tasks
kbenzie
pushed a commit
that referenced
this pull request
Aug 13, 2024
Command-buffer immediate command-list CTS fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #1951 (comment) there is an issue running the command-buffer CTS tests on L0 with command-lists enabled.
After investigating, this was because the CTS tests we're not using the output event parameter to command-buffer enqueue. In the L0 adapter code a path for registering an event with the queue to waiting on the workload was guarded by this event being set. Therefore
urQueueFinishwas not working as expected, as the queue was not aware of this work to wait on.Fixed by always registering the work to wait on with the queue, and miss out on propagation of the created event when user doesn't pass an output event, rather than not creating it at all.
DPC++ PR intel/llvm#15035