Skip to content

Command-buffer immediate command-list CTS fix #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omarahmed1111 merged 1 commit into from
Aug 13, 2024
Merged

Command-buffer immediate command-list CTS fix #1960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions source/adapters/level_zero/command_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,13 +1300,14 @@ ur_result_t waitForDependencies(ur_exp_command_buffer_handle_t CommandBuffer,
* @param[in] CommandBuffer The command buffer.
* @param[in] Queue The UR queue used to submit the command buffer.
* @param[in] SignalCommandList The command-list to append the barrier to.
* @param[out] Event The host visible event which will be returned to the user.
* @param[out][optional] Event The host visible event which will be returned
* to the user, if user passed an output parameter to the UR API.
* @return UR_RESULT_SUCCESS or an error code on failure
*/
ur_result_t createUserEvent(ur_exp_command_buffer_handle_t CommandBuffer,
ur_queue_handle_legacy_t Queue,
ur_command_list_ptr_t SignalCommandList,
ur_event_handle_t &Event) {
ur_event_handle_t *Event) {
// Execution event for this enqueue of the UR command-buffer
ur_event_handle_t RetEvent{};

Expand Down Expand Up @@ -1342,7 +1343,9 @@ ur_result_t createUserEvent(ur_exp_command_buffer_handle_t CommandBuffer,
&(CommandBuffer->SignalEvent->ZeEvent)));
}

Event = RetEvent;
if (Event) {
*Event = RetEvent;
}

return UR_RESULT_SUCCESS;
}
Expand Down Expand Up @@ -1405,9 +1408,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferEnqueueExp(
ZE2UR_CALL(zeCommandListAppendEventReset,
(SignalCommandList->first, CommandBuffer->AllResetEvent->ZeEvent));

if (Event) {
UR_CALL(createUserEvent(CommandBuffer, Queue, SignalCommandList, *Event));
}
// Appends a wait on the main command-list signal and registers output Event
// parameter with signal command-list completing.
UR_CALL(createUserEvent(CommandBuffer, Queue, SignalCommandList, Event));

UR_CALL(Queue->executeCommandList(SignalCommandList, false, false));

Expand Down