-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise MSVC warning level from /W3 to /W4 #2100
base: main
Are you sure you want to change the base?
Conversation
4a9f277
to
e8e086b
Compare
On GCC, |
I don't think extra warnings being introduced by new compilers is actually an issue, by default warnings are not treated as errors, that's only enabled with the |
6a0b9b3
to
568779e
Compare
c85cdf5
to
1c9da05
Compare
test/conformance/exp_command_buffer/update/buffer_fill_kernel_update.cpp
Show resolved
Hide resolved
1c9da05
to
2dd0821
Compare
2dd0821
to
3186a14
Compare
@oneapi-src/unified-runtime-level-zero-write do these changes look okay? |
3186a14
to
52f8ebf
Compare
52f8ebf
to
8e2f794
Compare
e7ee380
to
5627f44
Compare
@oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-level-zero-write please review |
5627f44
to
ccbfaa2
Compare
ccbfaa2
to
da462e9
Compare
This patch increases the warning level when using the MSVC compiler from `/W3` to `/W4` and fixes the issues found. Four warnings introduced by `/W4` are disabled, all related to variable name shadowing, as they overly prescriptive to valid code.
da462e9
to
05f2a1f
Compare
This patch increases the warning level when using the MSVC compiler from
/W3
to/W4
and fixes the issues found. Four warnings introduced by/W4
are disabled, all related to variable name shadowing, as they are overly prescriptive to valid code.intel/llvm#15745