Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][CUDA] Include STL headers in program.cpp #2174

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ProGTX
Copy link
Contributor

@ProGTX ProGTX commented Oct 4, 2024

This patch fixes the following build error on Windows:

source\adapters\cuda\program.cpp(73): error C2079: 'WorkGroupElements' uses undefined class 'std::array<uint32_t,3>'

Technically only <array> was sufficient for resolving it, but it's better to include everything that the file relies on.

This patch fixes the build error on Windows.
Technically only `<array>` was sufficient for resolving it,
but it's better to include everything that the file relies on.
@ProGTX ProGTX requested a review from a team as a code owner October 4, 2024 15:15
@MartinWehking
Copy link

Could you please clarify which build error this fixes?

@github-actions github-actions bot added the cuda CUDA adapter specific issues label Oct 4, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Oct 4, 2024

Ah, this reminds me I should do a Windows+CUDA build before merging #2100.

@MartinWehking
Copy link

Does this also affect the HIP adapter?

@kbenzie
Copy link
Contributor

kbenzie commented Oct 4, 2024

Is HIP adapter supported on Windows? I thought it wasn't.

@MartinWehking
Copy link

Is HIP adapter supported on Windows? I thought it wasn't.

Ah yes, that's true.

@ProGTX
Copy link
Contributor Author

ProGTX commented Oct 8, 2024

I've updated the description with the error.

Copy link

@MartinWehking MartinWehking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarongreig aarongreig merged commit 53c461b into oneapi-src:main Oct 11, 2024
154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA adapter specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants