-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include stdbool.h in API headers #3
Conversation
3296a90
to
f8062ef
Compare
Alternatively, perhaps we should rethink whether we use |
Thanks for your feedback @bashbaug . Good point, I did think it was a little odd the API was using More generally, APIs in the UR spec are using types from |
f8062ef
to
9c103cf
Compare
* `ur_api.h` makes use of `bool`. `ur_api.h` is a C header and in C the `bool` type is defined in `stdbool.h`, hence we should include `ur_api.h` in the API header.
9c103cf
to
289ae07
Compare
Closing in favor of #42. |
# This is the 1st commit message: parent 9824163 author Mikołaj Komar <mikolaj.komar@intel.com> 1734527193 +0000 committer Mateusz P. Nowak <mateusz.p.nowak@intel.com> 1738059437 +0000 Prepare ground for command_buffer in v2 Enforce in order list usage, and add initialization and destruction to buffer Add initial support of command buffers to adapter v2 Update UR calls handling Remove unnecessary comment Move not implemented command buffer commands to previous position Fix most issues with code Fix formatting and modify queue_api template Move command buffer cleanup to destructor Use cached command lists instead of created ones Remove not needed function and change phrasing Add initial implementation of command list manager Use list manager instead of custom implementation in queue Optimalize imports Remove not needed destructor Revert "Fix formatting" This reverts commit 545e577. # This is the commit message oneapi-src#2: Move command list close to the command buffer # This is the commit message oneapi-src#3: Moved try outside function block # This is the commit message oneapi-src#4: Move enqueue generic command list back to queue
# This is the 1st commit message: parent 9824163 author Mikołaj Komar <mikolaj.komar@intel.com> 1734527193 +0000 committer Mateusz P. Nowak <mateusz.p.nowak@intel.com> 1738059437 +0000 Prepare ground for command_buffer in v2 Enforce in order list usage, and add initialization and destruction to buffer Add initial support of command buffers to adapter v2 Update UR calls handling Remove unnecessary comment Move not implemented command buffer commands to previous position Fix most issues with code Fix formatting and modify queue_api template Move command buffer cleanup to destructor Use cached command lists instead of created ones Remove not needed function and change phrasing Add initial implementation of command list manager Use list manager instead of custom implementation in queue Optimalize imports Remove not needed destructor Revert "Fix formatting" This reverts commit 545e577. Move command list close to the command buffer Moved try outside function block Move enqueue generic command list back to queue Share events and lists between queue and command list manager Use ze events instead of ur in getSignalEvent # This is the commit message oneapi-src#2: Remove not needed structs and reformat code # This is the commit message oneapi-src#3: Fix PR comments
# This is the 1st commit message: parent 9824163 author Mikołaj Komar <mikolaj.komar@intel.com> 1734527193 +0000 committer Mateusz P. Nowak <mateusz.p.nowak@intel.com> 1738059437 +0000 Prepare ground for command_buffer in v2 Enforce in order list usage, and add initialization and destruction to buffer Add initial support of command buffers to adapter v2 Update UR calls handling Remove unnecessary comment Move not implemented command buffer commands to previous position Fix most issues with code Fix formatting and modify queue_api template Move command buffer cleanup to destructor Use cached command lists instead of created ones Remove not needed function and change phrasing Add initial implementation of command list manager Use list manager instead of custom implementation in queue Optimalize imports Remove not needed destructor Revert "Fix formatting" This reverts commit 545e577. Move command list close to the command buffer Moved try outside function block Move enqueue generic command list back to queue Share events and lists between queue and command list manager Use ze events instead of ur in getSignalEvent # This is the commit message oneapi-src#2: Remove not needed structs and reformat code # This is the commit message oneapi-src#3: Fix PR comments # This is the commit message oneapi-src#4: Fix ze function calling # This is the commit message oneapi-src#5: Fix access to some fields in command buffer v2 # This is the commit message oneapi-src#6: Fix compilation
ur_api.h
makes use ofbool
.ur_api.h
is a C header and in C thebool
type is defined instdbool.h
, hence we should includeur_api.h
in the API header.