Remove incorrect documentation from zerEnqueueMemBufferCopy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `zerEnqueueMemBufferCopy` does a linear copy between two buffers viewed as 1D contiguous memory, the description: *The source and destination 2D or 3D rectangular regions can have different shapes.* makes no sense in this context.
FranklandJack
force-pushed
the
remove_incorrect_details
branch
from
af248f2 to
ac31f90
Compare
AerialMantis
approved these changes
Nov 22, 2022
mateuszpn
added a commit
to Xewar313/unified-runtime
that referenced
this pull request
Jan 28, 2025
# This is the 1st commit message: parent 9824163 author Mikołaj Komar <mikolaj.komar@intel.com> 1734527193 +0000 committer Mateusz P. Nowak <mateusz.p.nowak@intel.com> 1738059437 +0000 Prepare ground for command_buffer in v2 Enforce in order list usage, and add initialization and destruction to buffer Add initial support of command buffers to adapter v2 Update UR calls handling Remove unnecessary comment Move not implemented command buffer commands to previous position Fix most issues with code Fix formatting and modify queue_api template Move command buffer cleanup to destructor Use cached command lists instead of created ones Remove not needed function and change phrasing Add initial implementation of command list manager Use list manager instead of custom implementation in queue Optimalize imports Remove not needed destructor Revert "Fix formatting" This reverts commit 545e577. Move command list close to the command buffer Moved try outside function block Move enqueue generic command list back to queue Share events and lists between queue and command list manager Use ze events instead of ur in getSignalEvent # This is the commit message oneapi-src#2: Remove not needed structs and reformat code # This is the commit message oneapi-src#3: Fix PR comments # This is the commit message oneapi-src#4: Fix ze function calling # This is the commit message oneapi-src#5: Fix access to some fields in command buffer v2 # This is the commit message oneapi-src#6: Fix compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zerEnqueueMemBufferCopydoes a linear copy between two buffers viewed as 1D contiguous memory, the description: The source and destination 2D or 3D rectangular regions can have different shapes. makes no sense in this context.