Add definitions in support of USM Import/Release functions. #578
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
suggested changes
Jun 7, 2023
Contributor
kbenzie
left a comment
kbenzie
left a comment
There was a problem hiding this comment.
These files are automatically generated from a YAML description of the API. Please read the Contributing Guide for infomation about how to go about making changes.
Contributor
|
@rdeodhar following up after this was discussed in the WG call. Given that these additions are intended to expose experimental Level Zero functionality they should also be defined as a Experimental Feature in Unified Runtime, #560 is a practical example of this. @gmlueck also noted that we should only define the API based on what is currently supported by Level Zero rather than the semantics that will be added at a later date. This maps well to our definition for an experimental feature, which do not require long term API/ABI stability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the definitions necessary for two new functions: USMImport and USMRelease.
USMImport converts host system memory into something akin to USM host memory.
USMRelease undoes the effect of a previous USMImport.
This functionality is used by SYCL to import/release host memory to speed up host <-> device data transfers.