[Experimental] Add command-buffers #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bensuo
force-pushed
the
ben/port-command-buffers
branch
from
fc305b6 to
047fa16
Compare
EwanC
reviewed
Jun 5, 2023
EwanC
reviewed
Jun 5, 2023
EwanC
approved these changes
Jun 6, 2023
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Looks good from my perspective
Contributor
There was a problem hiding this comment.
We need to add also COMMAND_BUFFER_SUPPORT_EXP in device.yml x_device_info_t to support this device info query.
Edit: This is resolved and was discussed in this comment
kbenzie
reviewed
Jun 7, 2023
Contributor
|
@Bensuo please rebase, run the |
- Adds support for command-buffers experimental feature - Add command-buffer desc type to common.yml - Add device info query for command-buffer support
- Add return codes to all cmdbuffer functions - Consistent naming for functions that append to a cmdbuffer
- Set command-buffer ordinal to 99 - Include license - Fix incorrect naming conventions - Make sync point parameters optional - Move and add explicit values to errors
Bensuo
force-pushed
the
ben/port-command-buffers
branch
from
e5f92ef to
5897875
Compare
Contributor
Author
omarahmed1111
approved these changes
Jun 8, 2023
kbenzie
approved these changes
Jun 8, 2023
EwanC
reviewed
Jun 8, 2023
kbenzie
added
the
experimental
Bensuo
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Jun 13, 2023
[Experimental] Add command-buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the PI command-buffer extension added in intel/llvm#9375 which is currently under review. The functions implemented do not cover all possible command types, only those that have actually been implemented in the linked PR.
Notes: