[SYCL][Graphs] Implement UR command-buffers #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
approved these changes
Jun 6, 2023
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Looks like an accurate port to me 😃
reble
approved these changes
Jun 7, 2023
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_command_buffer.cpp
Outdated
Show resolved
Hide resolved
sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero_command_buffer.hpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Jun 7, 2023
EwanC
approved these changes
Jun 9, 2023
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Still LGTM after recent pushes
- Move implementation of PI command buffers to UR
- Command-buffer support is now done through the PI/UR extension query - Only level zero backend reports extension
- Handler not checking whether we're in explicit mode when processing empty CG
Bensuo
force-pushed
the
ben/cmd-buffer-ur
branch
from
670c403 to
fb1bf95
Compare
- Using a temporary UR commit because upstream is out of date with recent changes
Collaborator
Author
|
This is now rebased on top of an updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: there are currently some issues with a few e2e tests which I am investigating but may not be actually related to these changes.
Changes are developed with this PR in the Unified Runtime which defines command-buffers for UR: oneapi-src/unified-runtime#560
PR is made against a temporary develop branch which has the UR L0 Adapter changes merged in to make it possible to review.
Once the changes have been reviewed we can update our develop branch and merge the changes in.