Optimize max map value size to reduce number of registers #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, both max map key size and max map value size were the same (about half of max map element size). However, key size can be much smaller than max limit and max value size doesn't benefit from smaller key. Improve this by computing max map value size to subtract encoded key size from max map element size. So large value can be stored along with small key to reduce number of slabs. While at it, also replace exported settings with exported functions.
fxamacker
added
performance
improvement
breaking change
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 64.61% 64.59% -0.02%
==========================================
Files 14 14
Lines 7991 7997 +6
==========================================
+ Hits 5163 5166 +3
- Misses 2152 2156 +4
+ Partials 676 675 -1
|
|
Nice! Does this need a state migration? |
@turbolent Yes, this is part of prep work for Atree Register Inlining (#292) which requires migration anyway. |
turbolent
approved these changes
Jun 28, 2023
fxamacker
added a commit
to onflow/cadence
that referenced
this pull request
Jun 29, 2023
This commit updates Cadence to use new Atree API - Array.Get() - OrderedMap.Get() - MaxInlineArrayElementSize() - MaxInlineMapKeySize() For more info, see Atree PRs: - onflow/atree#314 - onflow/atree#316 - onflow/atree#318
6 tasks
turbolent
pushed a commit
to onflow/cadence
that referenced
this pull request
Jan 26, 2024
This commit updates Cadence to use new Atree API - Array.Get() - OrderedMap.Get() - MaxInlineArrayElementSize() - MaxInlineMapKeySize() For more info, see Atree PRs: - onflow/atree#314 - onflow/atree#316 - onflow/atree#318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #313
Updates #296 #292 onflow/flow-go#1744
Description
Previously, both max map key size and max map value size were the same (about half of max map element size). However, key size can be much smaller than max limit and max value size didn't benefit from smaller key.
Optimize this by computing max map value size to subtract encoded key size from max map element size. So large value can be stored along with small key to reduce number of registers.
While at it, also replace exported settings with exported functions.
mainbranchFiles changedin the Github PR explorer