-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lint] Add Cadence 1.0 analyzer with basic linting rules #285
Conversation
9901b53
to
4fa14ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple remaining questions re: the parser/checker error handlers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SupunS could you please also have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Closes #287
Description
This PR adds a cadence 1.0 analyzer with initial linting rules which identify some instances of pre-Cadence 1.0 code. These diagnostics will display more verbose errors than syntax errors reported by the checker or lexical errors reported by the parser, potentially provide automatic fixes, as well as direct users to relevant documentation regarding how to upgrade their code.
This PR depends on the 2 following PRs:
and will not be valid until these PRs are merged & this PR is updated to the latest version of Cadence
master
branchFiles changed
in the Github PR explorer