Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LS] Add support for new analysis.Diagnostic information & CadenceV1Analyzer #286

Merged
merged 14 commits into from
Feb 22, 2024
Merged

[LS] Add support for new analysis.Diagnostic information & CadenceV1Analyzer #286

merged 14 commits into from
Feb 22, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 7, 2024 •
edited
Loading

Closes #293

Description

This PR adds language server support for new analysis.Diagnostic information as well as assigning a different severity to Cadence V1 Analyzer diagnostics.

Dependent on:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Feb 15, 2024
jribbink
jribbink commented Feb 20, 2024
View reviewed changes
languageserver/go.mod Outdated Show resolved Hide resolved
@jribbink jribbink mentioned this pull request Feb 20, 2024
Merged
6 tasks
@jribbink jribbink changed the title [LS] Add support for new analysis.Diagnostic information [LS] Add support for new analysis.Diagnostic information & CadenceV1Analyzer Feb 22, 2024
@jribbink jribbink marked this pull request as ready for review February 22, 2024 21:18
@turbolent turbolent merged commit 3681b8d into master Feb 22, 2024
6 checks passed
@turbolent turbolent deleted the jribbink/ls-diagnostic-update branch February 22, 2024 22:47
@turbolent
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees
No one assigned
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LS] Add support for new analysis.Diagnostic information
2 participants
@jribbink @turbolent