Type checking for authorized references #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…main of their map
…ntitlements that are valid for the referenced type
dsainati1
commented
Mar 29, 2023
…ence into sainati/entitled-references
Codecov Report
@@ Coverage Diff @@
## sainati/entitlements-checking #2405 +/- ##
================================================================
Coverage ? 78.39%
================================================================
Files ? 326
Lines ? 73178
Branches ? 0
================================================================
Hits ? 57369
Misses ? 13712
Partials ? 2097
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ence into sainati/entitled-references
SupunS
reviewed
May 12, 2023
SupunS
reviewed
May 12, 2023
…ence into sainati/entitled-references
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
…ce into sainati/entitled-references
…ence into sainati/entitled-references
…ence into sainati/entitled-references
Base automatically changed from
sainati/entitlements-checking
to
feature/entitlements
May 19, 2023 15:28
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/entitlements commit 7856e8a Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
…ce into sainati/entitled-references
turbolent
reviewed
May 29, 2023
turbolent
reviewed
May 31, 2023
There was a problem hiding this comment.
Looks good, great work!
I think we can merge this after the last couple things that are still open have been merged, or feel free to address them in a follow-up PR.
In the future it might be good to break PRs up more into smaller chunks, which makes them easier to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the implementation of onflow/flips#54, part of #2412
This implements type checking for the creation and usage of authorized/entitled references, as well as subtyping and access control
masterbranchFiles changedin the Github PR explorer