-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent migration tests from using out-of-sync data #3597
Merged
Merged
+59
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit ed99fbf Collapsed results for better readability
|
Currently, some migration tests reuse storage for migration. It can lead to tests failing when the storage cache gets out of sync with underlying storage. For example: 1. Use storage 1 to store valueA in public domain directly. 2. Use storage 2 to store valueB in public domain via ExecuteTransaction(). 3. Reuse storage 1 for migration. Here, migration only sees valueA from cache instead of both values. This commit prevents out-of-sync issues by creating new runtime.Storage for migrations instead of reusing old storage.
fxamacker
force-pushed
the
fxamacker/fix-migration-storage
branch
from
October 2, 2024 20:09
2bc6cf6
to
88c3cf0
Compare
turbolent
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some migration tests reuse storage for migration. It can lead to tests failing when the storage cache gets out of sync with underlying storage.
For example:
This PR prevents out-of-sync issues by creating new
runtime.Storage
for migrations instead of reusing old storage.Context
This test bug surfaced on the proof-of-concept I'm working on:
master
branchFiles changed
in the Github PR explorer