Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Account Storage Maps] Refactor migration #3680

Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Nov 14, 2024

Depends on #3678

Description

  • Simplify the bookkeeping in V2: only keep a simple map, an ordered map is unnecessary
  • Simplify the domain register migration to allow migration of a single account
  • For now, bring back the automatic migration of written-to accounts during commit.
    We'll keep discussing this in the upcoming sync with the Execution team.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from fxamacker November 15, 2024 00:07
@turbolent turbolent self-assigned this Nov 15, 2024
@turbolent turbolent marked this pull request as ready for review November 15, 2024 17:40
@turbolent turbolent requested a review from SupunS as a code owner November 15, 2024 17:40
@turbolent turbolent requested a review from jsproz November 15, 2024 17:40
runtime/storage.go Outdated Show resolved Hide resolved
return err
}

// TODO: is this all that is needed?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update of the bookkeeping is the same as before: Make V2 aware of the new account storage map, so it is not re-loaded, and consider the account no longer as V1. From what I can see this should be sufficient, but it's good to double check this is sufficient. @fxamacker

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other PR, I don't have a lot of context on the business logic. So I mostly reviewed for the general Go code.

@turbolent turbolent force-pushed the bastian/refactor-account-storage-2 branch from f309c0c to bff6187 Compare November 15, 2024 22:20
@turbolent
Copy link
Member Author

Merging into #3678 to have all changes needed to pass CI in one PR, as discussed in #3678 (comment)

@turbolent turbolent merged commit 6d95444 into bastian/refactor-account-storage Nov 15, 2024
@turbolent turbolent deleted the bastian/refactor-account-storage-2 branch November 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants