-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Account Storage Maps] Refactor migration #3680
[Account Storage Maps] Refactor migration #3680
Conversation
return err | ||
} | ||
|
||
// TODO: is this all that is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update of the bookkeeping is the same as before: Make V2 aware of the new account storage map, so it is not re-loaded, and consider the account no longer as V1. From what I can see this should be sufficient, but it's good to double check this is sufficient. @fxamacker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the other PR, I don't have a lot of context on the business logic. So I mostly reviewed for the general Go code.
f309c0c
to
bff6187
Compare
Merging into #3678 to have all changes needed to pass CI in one PR, as discussed in #3678 (comment) |
Depends on #3678
Description
We'll keep discussing this in the upcoming sync with the Execution team.
master
branchFiles changed
in the Github PR explorer