Make CompositeType.Members field an ordered map #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
force-pushed
the
supun/ordered-map-2
branch
8 times, most recently
from
d56c16f to
977b1a1
Compare
SupunS
force-pushed
the
supun/ordered-map-2
branch
from
977b1a1 to
a1bfd4e
Compare
SupunS
force-pushed
the
supun/ordered-map-1
branch
from
465709d to
be9dbdb
Compare
|
@SupunS can you please rebase on |
|
@turbolent Rebased to master. |
turbolent
reviewed
Feb 8, 2021
runtime/convertTypes.go
Outdated
Comment on lines
194
to
196
| member, ok := t.Members.Get(identifier) | ||
|
|
||
| if member.IgnoreInSerialization { | ||
| if !ok || member.IgnoreInSerialization { |
There was a problem hiding this comment.
Is there ever a case where the lookup would fail? Is it rather an implementation error when the lookup fails?
Same question below.
There was a problem hiding this comment.
AFAIU Fields are a subset of Members. So the lookup should always succeed.
Maybe a panic would be a good idea.
turbolent
reviewed
Feb 8, 2021
| testFunctionMember := structureType.Members["test"] | ||
|
|
||
| testFunctionMember, ok := structureType.Members.Get("test") | ||
| require.True(t, ok) |
|
@SupunS thanks for rebasing, looks good |
SupunS
force-pushed
the
supun/ordered-map-2
branch
4 times, most recently
from
1b4def8 to
d80fc38
Compare
SupunS
force-pushed
the
supun/ordered-map-2
branch
from
d80fc38 to
f287790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work towards #436
stringkeys and*MembervaluesCompositeType.Membersfield to the generated ordered map.For contributor use:
masterbranchFiles changedin the Github PR explorer