Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure iteration order is defined #436

Closed
2 of 3 tasks
turbolent opened this issue Nov 2, 2020 · 0 comments · Fixed by #450
Closed
2 of 3 tasks

Ensure iteration order is defined #436

turbolent opened this issue Nov 2, 2020 · 0 comments · Fixed by #450

Comments

@turbolent
Copy link
Member

turbolent commented Nov 2, 2020

Issue To Be Solved

To make the checking process deterministic, non-deterministic constructs in GO must be avoided.
One such construct in Go is the iteration over maps, which has no defined order.

Ensure there is no iteration over maps.

Solution

  • Refactor iteration over maps to a defined iteration order
  • Find or write an analysis pass that prohibits iteration over maps and integrate it into CI
@turbolent turbolent self-assigned this Nov 2, 2020
@turbolent turbolent added P-Low and removed P-High labels Nov 27, 2020
@turbolent turbolent modified the milestones: Sprint 30 - Post Beta Mainnet - Part 13 [Jan 18 -Jan 29], Sprint 31 - Post Beta Mainnet - Part 14 [Feb 1 -Feb 12] Jan 27, 2021
@sifmoon sifmoon modified the milestones: Sprint 31 - Post Beta Mainnet - Part 14 [Feb 1 -Feb 12], Sprint 32 - Post Beta Mainnet - Part 14 [Feb 15 -Feb 26] Feb 17, 2021
@turbolent turbolent added P-High and removed P-Low labels Feb 18, 2021
@turbolent turbolent changed the title Ensure iteration order is defined when checking Ensure iteration order is defined Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants