Make interface sets ordered and thread-safe #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
approved these changes
Feb 17, 2021
Comment on lines
21
to
+23
| //go:generate go run github.com/cheekybits/genny -pkg=sema -in=../common/orderedmap/orderedmap.go -out=ordered_map_string_type.go gen "KeyType=string ValueType=Type" | ||
| //go:generate go run github.com/cheekybits/genny -pkg=sema -in=../common/orderedmap/orderedmap.go -out=ordered_map_string_member.go gen "KeyType=string ValueType=*Member" | ||
| //go:generate go run github.com/cheekybits/genny -pkg=sema -in=../common/orderedmap/orderedmap.go -out=ordered_map_interfacetype_struct.go gen "KeyType=*InterfaceType ValueType=struct{}" |
There was a problem hiding this comment.
Would it be good to move all the generated maps to a single place like runtime/commons/orderedmap, eventually?
There was a problem hiding this comment.
I'm currently distinguishing between "primitive" ordered maps that are useful in multiple packages (e.g. string-to-string), and sema-specific maps (generated by this file, e.g. string-to-type).
We can't move the sema-specific types to common, because common is used by multiple other packages, and that would introduce a circular dependency (common is at the bottom of the dependency chain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #436
Description
Composite types and restricted types have sets of interfaces: Composite types' conformances, and restricted types' restrictions.
Make the sets deterministic by using ordered maps.
Also, initialize these sets in a thread-safe way, as the elaboration they might be contained in will be used concurrently in the future.
For contributor use:
masterbranchFiles changedin the Github PR explorer