Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource info merging #606

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

turbolent
Copy link
Member

Work towards #436

Description

Improve how resource info of then/else branches is merged into the parent scope.
Avoid non-deterministic iteration and remove the old pre-allocation of all infos from the branches (BranchesResourceInfo and BranchesResourceInfos)


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent force-pushed the bastian/improve-resource-merging branch from c2335b7 to bb62da6 Compare February 18, 2021 15:28
@turbolent turbolent mentioned this pull request Feb 19, 2021
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the business logic in this section, but the code-changes look good to me.

@turbolent turbolent merged commit 6b3a002 into master Feb 19, 2021
@turbolent turbolent deleted the bastian/improve-resource-merging branch February 19, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants