Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address network validation #60

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Add address network validation #60

merged 6 commits into from
Oct 27, 2023

Conversation

jribbink
Copy link
Contributor

Closes #59

Description

Adds validation to determine whether a supplied account address for funding an account belongs to the correct network (testnet).


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink requested a review from alse as a code owner October 16, 2023 23:55
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flow-faucet-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:56pm

Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bthaile
Copy link
Contributor

bthaile commented Oct 20, 2023

@jribbink Check the tests, failing on address checks

@jribbink
Copy link
Contributor Author

@jribbink Check the tests, failing on address checks

It looks like all of these tests were previously failing

@bthaile bthaile enabled auto-merge October 27, 2023 16:11
@bthaile bthaile disabled auto-merge October 27, 2023 16:11
@bthaile bthaile merged commit 8d30caf into main Oct 27, 2023
@bthaile bthaile deleted the jribbink/network-validation branch October 27, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous error when address is for different network
2 participants