Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CoverageReport through EmulatorGateway #995

Merged

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Apr 25, 2023

Work towards: onflow/developer-grants#132
Depends on: onflow/flow-emulator#362

Description

This will allow tools that build on-top of the Flow Emulator through the Flow CLI, to be able to inject/retrieve the CoverageReport object.
Context: bjartek/overflow#107


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter
Copy link
Collaborator Author

m-Peter commented Apr 25, 2023

cc @bjartek

Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you

@bjartek
Copy link
Collaborator

bjartek commented Apr 25, 2023

Amazing!

@codecov-commenter
Copy link

Codecov Report

Merging #995 (ca0fce8) into master (a3dd185) will increase coverage by 35.84%.
The diff coverage is 56.75%.

@@             Coverage Diff             @@
##           master     #995       +/-   ##
===========================================
+ Coverage    2.49%   38.34%   +35.84%     
===========================================
  Files           5       37       +32     
  Lines         441     1836     +1395     
===========================================
+ Hits           11      704      +693     
- Misses        429     1050      +621     
- Partials        1       82       +81     
Flag Coverage Δ
unittests 38.34% <56.75%> (+35.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/accounts/create-interactive.go 0.00% <0.00%> (ø)
internal/accounts/staking-info.go 0.00% <0.00%> (ø)
internal/keys/generate.go 16.00% <0.00%> (ø)
internal/super/dev.go 0.00% <0.00%> (ø)
internal/super/files.go 12.35% <ø> (ø)
internal/super/output.go 0.00% <0.00%> (ø)
internal/super/project.go 0.00% <0.00%> (ø)
internal/super/setup.go 0.00% <0.00%> (ø)
internal/transactions/sign.go 37.50% <21.42%> (ø)
internal/signatures/verify.go 47.91% <50.00%> (ø)
... and 26 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sideninja sideninja merged commit 086ca8c into onflow:master Apr 25, 2023
@m-Peter m-Peter deleted the emulator-gateway-expose-coverage-report branch April 28, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants