Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CoverageReport through Emulator interface #362

Merged

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Apr 25, 2023

Work towards: onflow/developer-grants#132

Description

This will allow tools that build on-top of the Flow Emulator, to be able to inject/retrieve the CoverageReport object.
Context: bjartek/overflow#107


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@m-Peter
Copy link
Contributor Author

m-Peter commented Apr 25, 2023

cc @bjartek

@sideninja
Copy link
Contributor

Check the tests.

@bluesign
Copy link
Collaborator

I thinks mocks need to regenerated @m-Peter (make generate)

@m-Peter
Copy link
Contributor Author

m-Peter commented Apr 25, 2023

On it 🙏

@codecov-commenter
Copy link

Codecov Report

Merging #362 (2e1da89) into master (acb82b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   47.39%   47.39%           
=======================================
  Files          26       26           
  Lines        3397     3397           
=======================================
  Hits         1610     1610           
  Misses       1656     1656           
  Partials      131      131           
Flag Coverage Δ
unittests 47.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blockchain.go 68.10% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sideninja
Copy link
Contributor

@m-Peter ok to merge?

@m-Peter
Copy link
Contributor Author

m-Peter commented Apr 25, 2023

@sideninja Sure, if it's OK for you, let's merge 🙏

@sideninja sideninja merged commit 5c374a6 into onflow:master Apr 25, 2023
@sideninja
Copy link
Contributor

@m-Peter I will tag and you can update the PR in CLI to the tagged version

@m-Peter
Copy link
Contributor Author

m-Peter commented Apr 25, 2023

Perfect 💯💯💯

@m-Peter m-Peter deleted the emulator-interface-expose-coverage-report branch April 25, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants