Emulator .git compatibility for --persist #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesign
requested review from
janezpodhostnik,
psiemens,
sideninja and
turbolent
as code owners
sideninja
reviewed
Nov 2, 2021
| MetricsPath = "/metrics" | ||
| LivenessPath = "/live" | ||
| MetricsPath = "/metrics" | ||
| EmulatorApiPath = "/api/" |
There was a problem hiding this comment.
Would it make more sense for this to be /emulator since the API is vague and then you would have /emulator/snapshot. Do you have some reasons?
|
Had to submit a new one after cleaning, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLIP Fest issue: CLI Feature: State management #22
Description
This PR is for issue #22
PS: Better to merge after dev-wallet launcher