Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Feature: State management - Milestone 1 #102

Merged
merged 2 commits into from
Nov 5, 2021
Merged

CLI Feature: State management - Milestone 1 #102

merged 2 commits into from
Nov 5, 2021

Conversation

bluesign
Copy link
Contributor

@bluesign bluesign commented Oct 30, 2021 •
edited
Loading

CLI Feature: State management - Milestone 1

Description

This PR is for issue #22

  • Adds .git compatibilty to persistence storage
  • Adds emulator HTTP API endpoint
  • Implements /api/snapshot/{name} command for state management

Submission Links & Documents

Requirements Check

  • Completed requirements

##Example Result

Screen Shot 2021-10-30 at 13 30 15

@kerrywei kerrywei requested a review from sideninja November 1, 2021 17:45
@kerrywei
Copy link

kerrywei commented Nov 4, 2021

linking the new PR: onflow/flow-emulator#92

sideninja
sideninja approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on the PR. Great work. 🎉

@kerrywei
Copy link

kerrywei commented Nov 5, 2021

Merging in this PR per Gregor's approval. I'll leave it between @sideninja and @bluesign to figure out properly merge in PR onflow/flow-emulator#92

@kerrywei kerrywei merged commit 49de151 into onflow:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideninja sideninja sideninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluesign @kerrywei @sideninja