-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.git layer and API for snapshots ( for --persist ) #92
Conversation
…-emulator into emulator_git_layer
@sideninja I stuck in those conflicts, this time tidy didn't help, any idea here? |
I was testing the state management API and one thing that I would change is logging. Depending on the verbosity of logs you either see the first logs (non-verbose) or second (verbose). I feel that the first logs are too verbose for non-verbose mode. I also think both are missing a log that would say the state was either created or changed, so for example when I would create a new state I would get a log in sense of
Verbose
Another thing that I feel could be useful is for API to have some sort of response body, now you indicate success with status which is great, but it would be nice to have some response back weather a new state was created or weather the emualtor switch to that state, I could even argue it would be better to have creation of state limited to POST method and switching to PUT but I'm totally fine if it stays this way as long as there is some response so the client can now if the state was created or switched to. As far as the code goes it's very well written, I just left some more aesthetic comments |
This is really awesome log! 🎉
|
I will help you after the last commit. |
Description
I had to do a second PR as GitHub didn't allow me to change source branch somehow.
FLIP Fest issue: CLI Feature: State management #22
Description
This PR is for issue #22