-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NFT serialization #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 18, 2024 21:55
6e23112
to
eb4a9cf
Compare
sisyphusSmiling
force-pushed
the
add-bridge-interface
branch
2 times, most recently
from
March 18, 2024 22:21
4755a6c
to
516ecc6
Compare
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 18, 2024 22:21
eb4a9cf
to
8863de4
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 18, 2024 23:43
04ad5f0
to
1cbb349
Compare
sisyphusSmiling
force-pushed
the
add-bridge-interface
branch
from
March 20, 2024 03:22
516ecc6
to
7c5ad95
Compare
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 20, 2024 03:23
97488c2
to
199c576
Compare
bluesign
reviewed
Mar 20, 2024
sisyphusSmiling
force-pushed
the
add-bridge-interface
branch
from
March 26, 2024 00:02
7c5ad95
to
f8c0346
Compare
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 26, 2024 00:02
48de417
to
e81602e
Compare
Closed
6 tasks
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 29, 2024 20:06
e81602e
to
2dbe4e1
Compare
…n on deployERC721
sisyphusSmiling
force-pushed
the
add-serialization
branch
from
March 29, 2024 20:18
2dbe4e1
to
3c57f2e
Compare
6 tasks
nvdtf
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
joshuahannan
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #17
Related: #15
Stacked on #19
Description
This PR introduces a Cadence test framework covering new serialization functionality. Serialization is used on bridging a Cadence-native NFT to EVM, serializing its metadata in conformance with widely used metadata standards (OpenSea's metadata format), and committing the returned data URL JSON string as the
tokenURI
value in the target ERC721. The same approach is taken to retrieve contract-level metadata, committing the data URL as thecontractURI
value. In both cases, project-specified URIs defined inCrossVMNFT.EVMBridgedMetadata
views are checked first, and serialization is leveraged as a fallback in the event projects did not specify token- or contract-level URIs.Source contracts are treated as ground truth for NFT metadata, so bridging from native VMs to non-native VMs results in a recommitment of URI values. This means that if metadata will be "synced" to the non-native contract upon bridging between VMs based on state at the time of bridging.
For contributor use:
master
branchFiles changed
in the Github PR explorer