Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial bridge tests #22

Closed
wants to merge 0 commits into from

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Mar 21, 2024

Related: #15
Stacked on #19 and #20

Description

[DRAFT] Adding test coverage for the happy path now that EVM support has been built into CLI, but running into issues largely due to the design decision to integrate bridging functionality into the COA resource.

The issues break down essentially to:

  • Currently, EVMBridgeRouter enables calls from the COA to be routed to FlowEVMBridge. This functionally works, but limitations in the test environment make testing impossible at the moment.
  • It's required that EVMBridgeRouter be deployed to that same account as EVM since on deployment it configures a Router resource in contract account storage for calls from EVM to be routed through.
  • However, I can't add the service account as an alias to EVMBridgeRouter as the service account and deploy nor can I deploy the contract from encoded Cadence as it appears I'm not allowed to alter service account state from the test environment.

Posting as draft to serve as coordination point to unblock here.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling changed the title Add bridge tests Add initial bridge tests Mar 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (e81602e) to head (fe07489).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           add-serialization      #22      +/-   ##
=====================================================
+ Coverage              58.92%   63.37%   +4.45%     
=====================================================
  Files                      5       13       +8     
  Lines                    297      598     +301     
=====================================================
+ Hits                     175      379     +204     
- Misses                   122      219      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants