[Flow EVM] code and doc clean up #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
commented
Jul 24, 2024
Comment on lines
+401
to
+407
| // check balance is not prone to rounding error | ||
| if types.BalanceConversionToUFix64ProneToRoundingError(call.Value) { | ||
| return types.NewInvalidResult( | ||
| call.Transaction(), | ||
| types.ErrWithdrawBalanceRounding), nil | ||
| } | ||
|
|
There was a problem hiding this comment.
This logic was moved from the handler level to here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6252 +/- ##
==========================================
+ Coverage 41.44% 41.47% +0.02%
==========================================
Files 2009 2009
Lines 142990 142998 +8
==========================================
+ Hits 59268 59302 +34
+ Misses 77540 77522 -18
+ Partials 6182 6174 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ithub.com:onflow/flow-go into ramtin/evm-code-cleanup-and-doc-improvement-part2
janezpodhostnik
approved these changes
Jul 24, 2024
sideninja
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up and improves documentation for flow EVM. It doesn't include any major change, mostly fixing typos and removing code duplicates