Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] port of #6295 to previewnet #6308

Merged

Conversation

j1010001
Copy link
Member

@j1010001 j1010001 commented Aug 8, 2024

There are quite a few changes in #6252 which did not make it on previewnet branch, which makes this quite difficult to port.

@j1010001 j1010001 changed the base branch from master to feature/crescendo-previewnet August 8, 2024 22:50
@j1010001 j1010001 removed the request for review from janezpodhostnik August 8, 2024 23:13
Copy link
Contributor

@ramtinms ramtinms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ramtinms ramtinms changed the title port #6295 to previewnet [Flow EVM] port #6295 to previewnet Aug 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 41.53%. Comparing base (7e9174b) to head (f7c06ad).

Files Patch % Lines
fvm/evm/testutils/contract.go 0.00% 8 Missing ⚠️
fvm/evm/emulator/state/delta.go 66.66% 2 Missing and 2 partials ⚠️
fvm/evm/emulator/state/base.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/crescendo-previewnet    #6308      +/-   ##
================================================================
- Coverage                         42.88%   41.53%   -1.35%     
================================================================
  Files                              1674     1992     +318     
  Lines                            123736   141576   +17840     
================================================================
+ Hits                              53061    58809    +5748     
- Misses                            65183    76639   +11456     
- Partials                           5492     6128     +636     
Flag Coverage Δ
unittests 41.53% <38.09%> (-1.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms changed the title [Flow EVM] port #6295 to previewnet [Flow EVM] port of #6295 and #6295 to previewnet Aug 9, 2024
@j1010001 j1010001 changed the title [Flow EVM] port of #6295 and #6295 to previewnet [Flow EVM] port of #6295 to previewnet Aug 9, 2024
@j1010001 j1010001 merged commit 7a5e079 into feature/crescendo-previewnet Aug 9, 2024
55 checks passed
@j1010001 j1010001 deleted the jan/port-pr6295-to-previewnet branch August 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants