Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Deprecate legacy self destruct in the storage #6289

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Jul 31, 2024

This PR

  • Deprecates the legacy self-destruct functionality inside the StateDB
  • Fixes the issue reported here

@ramtinms ramtinms marked this pull request as ready for review July 31, 2024 19:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.47%. Comparing base (c5b9e46) to head (13f48dc).

Files Patch % Lines
fvm/evm/emulator/state/delta.go 33.33% 1 Missing and 1 partial ⚠️
fvm/evm/emulator/state/stateDB.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6289   +/-   ##
=======================================
  Coverage   41.46%   41.47%           
=======================================
  Files        2009     2009           
  Lines      143025   143028    +3     
=======================================
+ Hits        59311    59325   +14     
+ Misses      77540    77529   -11     
  Partials     6174     6174           
Flag Coverage Δ
unittests 41.47% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sideninja sideninja enabled auto-merge August 1, 2024 12:30
@ramtinms ramtinms disabled auto-merge August 7, 2024 14:42
@ramtinms ramtinms added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit 2bd1062 Aug 7, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/evm-depricate-legacy-self-destruct branch August 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants