[Flow EVM] Backport of #6289 #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/crescendo-previewnet #6290 +/- ##
================================================================
+ Coverage 41.54% 41.55% +0.01%
================================================================
Files 1992 1992
Lines 141553 141556 +3
================================================================
+ Hits 58802 58827 +25
+ Misses 76627 76609 -18
+ Partials 6124 6120 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sideninja
approved these changes
Aug 2, 2024
SupunS
approved these changes
Aug 2, 2024
Comment on lines
+211
to
+215
| // if already set to be self destructed, return | ||
| _, found := d.toBeDestructed[addr] | ||
| if found { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Not sure: should this maybe checked before other (address exist) check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6289