[EVM] Fix wrapped tracer panic #6293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6293 +/- ##
==========================================
+ Coverage 41.46% 41.49% +0.02%
==========================================
Files 2009 2009
Lines 143025 143032 +7
==========================================
+ Hits 59311 59345 +34
+ Misses 77540 77516 -24
+ Partials 6174 6171 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
approved these changes
Aug 5, 2024
janezpodhostnik
approved these changes
Aug 12, 2024
|
closing this one since #6327 covers similar changes |
auto-merge was automatically disabled
August 13, 2024 16:34
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes panics that occurred when checking if the tracer has hooks set, since a wrapped tracer was provided all hooks were set, but internally in the wrapped tracer we didn't check again so if the source tracer didn't set them (which call tracer doesn't) it panicked.