[Flow EVM] patch evm debug tracer to collect results and reset internal state after each tx execution #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6327 +/- ##
==========================================
- Coverage 42.37% 40.46% -1.92%
==========================================
Files 1584 1322 -262
Lines 116430 87238 -29192
==========================================
- Hits 49341 35299 -14042
+ Misses 62106 48603 -13503
+ Partials 4983 3336 -1647
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
commented
Aug 13, 2024
Comment on lines
-220
to
-229
| defer func() { | ||
| if proc.evm.Config.Tracer.OnTxEnd != nil { | ||
| j := i | ||
| res := batchResults[j] | ||
| if err == nil && res != nil { | ||
| proc.evm.Config.Tracer.OnTxEnd(res.Receipt(), res.ValidationError) | ||
| } | ||
| } | ||
| }() | ||
|
|
There was a problem hiding this comment.
no need to use defer as we don't want to collect the results on unhappy cases
janezpodhostnik
approved these changes
Aug 13, 2024
zhangchiqing
approved these changes
Aug 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracer can be used for multiple transactions and later collect results being called. We need to support storing interim results until the collection time.
Unfortunately, the call tracer is stateful and if not cleaned up could result in bugs. for example, a failed transaction might change the internal state of the call tracer and the next transaction would start from an invalid state. This usually result in an "incorrect number of top-level calls" error.
This PR updates the tracer to collect and hold on to the tracing results after each transaction execution (onTxEnd) and reset the internal state of the tracer before each transaction execution (onTxStart).
It also makes the trace collection during batchRun function more clear.