Cadence Account Storage Map Migration

[turbolent]

Implement the migration logic for onflow/cadence#3584

• Add a new system contract AccountV2Migration, which is deployed to the service account during bootstrapping. Its Admin resource is able to trigger the migration for the next batch of accounts to be migrated, by calling the injected scheduleAccountV2Migration function
• Expose a new function fun scheduleAccountV2Migration(addressStartIndex: UInt64, count: UInt64): Bool to the new contract AccountV2Migration in the service account. It generates the addresses in the given range, and schedules the migration to the new account storage format V2. It essentially just calls the internal Go function runtime.Storage.ScheduleV2Migration() provided by Cadence.

[fxamacker]

@turbolent Thanks for working on this part of the integration!

Do we want to create a feature branch and target this PR to the feature branch?

[turbolent]

@onflow/flow-cadence-execution is there a way to call accountV2Migration.DeclareScheduleAccountV2MigrationFunction during bootstrapping?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 76.44788% with 61 lines in your changes missing coverage. Please review.

Project coverage is 41.19%. Comparing base (f0d7ec9) to head (b5ab3c4).

Files with missing lines	Patch %	Lines
fvm/accountV2Migration/contract.go	70.45%	30 Missing and 9 partials ⚠️
fvm/runtime/reusable_cadence_runtime.go	45.45%	12 Missing ⚠️
cmd/execution_builder.go	0.00%	4 Missing ⚠️
fvm/systemcontracts/system_contracts.go	66.66%	3 Missing ⚠️
utils/unittest/execution_state.go	0.00%	2 Missing ⚠️
model/flow/chain.go	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6761      +/-   ##
==========================================
- Coverage   43.29%   41.19%   -2.10%     
==========================================
  Files        1558     2131     +573     
  Lines      139443   186566   +47123     
==========================================
+ Hits        60366    76865   +16499     
- Misses      74026   103264   +29238     
- Partials     5051     6437    +1386     

Flag	Coverage Δ
unittests	41.19% <76.44%> (-2.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[janezpodhostnik]

@turbolent during bootstrapping you have access to the function invokeMetaTransaction to that function you have to pass an fvm context.

When you want to run DeclareScheduleAccountV2MigrationFunction you can create a child context NewContextFromParent to which you add WithReusableCadenceRuntimePool and add the new cadence runtime pool.

Let me know if that helps.

[turbolent]

@janezpodhostnik Thanks! It turned out that setting up the functions in the runtime won't work, because an environments chain ID might change (default config chain is MN, but then actual chain is e.g. Emulator). I refactored the code to be similar to the EVM setup, i.e. declaring the functions in the transaction invoker and in the script invoker.

[turbolent]

@fxamacker I fixed a few things and added a test in 8b597cb which demonstrates that the migration of the service account works. Next step is probably to write an integration test which does this using the system chunk transaction, but I'm very new to this. Maybe someone from @onflow/flow-cadence-execution can take this on or at least point me in the right direction?

[fxamacker]

@turbolent Thanks for adding the test and other updates!

Would you like me to start reviewing this PR or should I wait until integration test is added and DRAFT status is removed? No rush, just checking before I begin something needed next week.

[turbolent]

@fxamacker Feel free to already start reviewing it. We'll probably want to have the integration tests before we merge, but feedback is already appreciated, thanks!

[fxamacker]

Nice! 👍 I left one minor comment about possibility of automatically disabling batch migration by adding and using something like a max address index.