Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] add nWorker to verify execution result #6830

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

zhangchiqing
Copy link
Member

Speed up the verify execution result command by adding a nWorker parameter which allows the verification to run concurrently.

a n2-highcpu-32 used to run at 1.5 block / second, but with this change a n2-highcpu-48 instance running with nWorker=30 can complete 10K blocks verification in 3 mins, which is 55 blocks / second.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 76.31579% with 18 lines in your changes missing coverage. Please review.

Project coverage is 41.00%. Comparing base (45950a7) to head (05c552f).

Files with missing lines Patch % Lines
cmd/util/cmd/verify_execution_result/cmd.go 0.00% 9 Missing ⚠️
engine/verification/verifier/verifiers.go 86.56% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6830      +/-   ##
==========================================
+ Coverage   40.98%   41.00%   +0.02%     
==========================================
  Files        2103     2103              
  Lines      184900   184963      +63     
==========================================
+ Hits        75783    75850      +67     
+ Misses     102750   102746       -4     
  Partials     6367     6367              
Flag Coverage Δ
unittests 41.00% <76.31%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit dde2718 Dec 20, 2024
55 checks passed
@zhangchiqing zhangchiqing deleted the leo/verify-execution-result-concurrent branch December 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants