Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport v0.37 add nWorker to verify execution result #6831

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

zhangchiqing
Copy link
Member

Backport #6830

@zhangchiqing zhangchiqing requested review from fxamacker, peterargue and janezpodhostnik and removed request for fxamacker December 19, 2024 22:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 76.31579% with 18 lines in your changes missing coverage. Please review.

Project coverage is 41.52%. Comparing base (0507f92) to head (41457ae).

Files with missing lines Patch % Lines
cmd/util/cmd/verify_execution_result/cmd.go 0.00% 9 Missing ⚠️
engine/verification/verifier/verifiers.go 86.56% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            v0.37    #6831   +/-   ##
=======================================
  Coverage   41.51%   41.52%           
=======================================
  Files        2032     2032           
  Lines      181451   181514   +63     
=======================================
+ Hits        75338    75381   +43     
- Misses      99882    99896   +14     
- Partials     6231     6237    +6     
Flag Coverage Δ
unittests 41.52% <76.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing merged commit a2ad9e6 into v0.37 Dec 20, 2024
55 checks passed
@zhangchiqing zhangchiqing deleted the leo/v0.37-verify-execution-result-concurrent branch December 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants