-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major LSP refactoring #238
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onflow/flow-playground/AUJ9zRMbjYaQhuWmxzVKZdJemXn3 |
can we provide a test plan in the PR description? such a big change deserves thorough testing |
That's a really good point. I will provide test plan, when I finish last two issues I've spotted:
|
Alright! |
There were multiple race-conditions between Language Client, Server, Monaco Editor and React state, which lead to a series of tricky to debug errors.
Planned for next release: