Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major LSP refactoring #238

Merged
merged 49 commits into from
Apr 14, 2022
Merged

Major LSP refactoring #238

merged 49 commits into from
Apr 14, 2022

Conversation

MaxStalker
Copy link
Contributor

@MaxStalker MaxStalker commented Apr 5, 2022

There were multiple race-conditions between Language Client, Server, Monaco Editor and React state, which lead to a series of tricky to debug errors.

  • Client/Server communication is moved into separate context for dissecting the problem and later ease of use
  • Automatically update code, when switching between editors to pickup latest changes in contracts and pass them to Language Server for verification
  • Refactored data handling, styles and components into separate files for better DevEx

Planned for next release:

  • Updated Language Server package, which now does not cache

@MaxStalker MaxStalker requested a review from 10thfloor as a code owner April 5, 2022 17:06
@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-playground/AUJ9zRMbjYaQhuWmxzVKZdJemXn3
✅ Preview: https://flow-playground-git-max-language-server-refactoring-onflow.vercel.app

@vercel vercel bot temporarily deployed to Preview April 8, 2022 10:04 Inactive
@vercel vercel bot temporarily deployed to Preview April 8, 2022 10:47 Inactive
@vercel vercel bot temporarily deployed to Preview April 8, 2022 10:55 Inactive
@kerrywei
Copy link

can we provide a test plan in the PR description? such a big change deserves thorough testing

@MaxStalker
Copy link
Contributor Author

can we provide a test plan in the PR description? such a big change deserves thorough testing

That's a really good point. I will provide test plan, when I finish last two issues I've spotted:

  • for some reason language server is taking old code to get a list of arguments
  • sometimes we see that LS can't find model on the editor (probably some severed link during updated)

@vercel vercel bot temporarily deployed to Preview April 12, 2022 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview April 12, 2022 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview April 12, 2022 18:59 Inactive
@MaxStalker
Copy link
Contributor Author

Alright!
The issues should be resolved now :)

@psiemens psiemens changed the base branch from master to staging April 14, 2022 17:07
@MaxStalker MaxStalker merged commit 5aaaffe into staging Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants