Create POST-MORTEM document #249
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onflow/flow-playground/869EKjN2oYiduRtXqdS98Knn8ogg |
|
|
||
| We've used the same trick as previously implemented in VS Code extension - add new line character at the eof, them add | ||
| timeout and revert code to original state. This will "trick" editor into thinking that code was changed and need to be | ||
| checked for errors again, catching new changes on contract in the process. Win-win! :) |
There was a problem hiding this comment.
@MaxStalker if my understanding is correct -- the problem was when a user switched back to script while language server is not fully done with processing the changes made, it would result in error.
But is the solution mentioned here the appropriate fix? It sounds like we are adding an unnecessary EOF just for the sake of triggering some actions. could there be a cleaner way to handle this? I'm not familiar with the code base but by thinking aloud, is this possible: do not allow transaction/script/contract view switch until language server is fully restarted and having the latest information?
There was a problem hiding this comment.
It's not really about the latest state of the language server, but rather about the way to ask language server to run the check again. I couldn't find a way to trigger re-check manually and not sure it actually exposed on Monaco editor 🤷♂️
And we don't add any footprint to the file, as we remove new line character after a small delay, which in turn triggers recheck.
Closes: #239
Description
New document is created to capture all the valuable information, debugging processes and insights developers could get
during the process of Playground improvement.
Initial edit include information about recent work on #238.