Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter clause for BoolQuery #48

Merged
merged 1 commit into from
Dec 24, 2015
Merged

Add filter clause for BoolQuery #48

merged 1 commit into from
Dec 24, 2015

Conversation

mvar
Copy link
Member

@mvar mvar commented Dec 18, 2015

This PR adds filter type support for bool query (Elasticsearch 2.0 feature).

This will allow us to deprecate all filters and implement full "query in filter context" support.

@mvar mvar added the qa label Dec 18, 2015
@saimaz
Copy link
Member

saimaz commented Dec 18, 2015

This is for ES ~2.0 only, need to think how to switch the test cases for ES 1.* and 2.*

@saimaz
Copy link
Member

saimaz commented Dec 18, 2015

Question is do we need to test this bundle on 1.* at all?

@mvar
Copy link
Member Author

mvar commented Dec 18, 2015

I think at least until next major release we should test on ES 1.* and 2.*. In this case I have added unit test only, so it will run in any environment. We need to discuss more about functional tests.

Don't merge this yet.

@murnieza
Copy link
Contributor

IMHO tests should be executed on both 1.* and 2.* ES vestions.

We can have different test suites and group tests based on which ES versions they should pass.

@mvar
Copy link
Member Author

mvar commented Dec 18, 2015

After discussion with @murnieza about different environments for functional tests we came up with such ideas:

We shouldn't use test suites for different ES versions as it requires to have specific file naming/structure.
PHPUnit has @group annotation. That could be a solution.

@mvar mvar changed the title Add filter type for BoolQuery Add filter clause for BoolQuery Dec 22, 2015
@saimaz saimaz merged commit b18e3f6 into ongr-io:master Dec 24, 2015
@saimaz saimaz removed the qa label Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants