Fix nested query in case "bool" with single "must" given #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimaz
added a commit
that referenced
this pull request
Dec 24, 2015
Fix nested query in case "bool" with single "must" given
|
Merged, but IMO we need few more test cases with different queries inside for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
This PR deprecates
BoolQuery::isRelevant()because it complicates everything. Too many places uses that complicated logic. Idea is "keep things simple, use single (full) query structure".After these changes queries with single must bool will look like this:
{"bool":{"must":[{"match_all":[]}]}}Instead of this:
{"match_all":[]}Both ways are valid and equal. This does not influence results returned by Elasticsearch.
In the future we could simplify structure again, BUT only if we could do that in
BoolQueryitself. That would be a BC break. I think each query class itself should return full array ([type=>data_array]).Please merge this only after #48 is merged.