fix: PhrasingElementExpression.cs - check empty string in text element#186
Merged
onizet merged 1 commit intoonizet:devfrom Jan 20, 2025
Merged
fix: PhrasingElementExpression.cs - check empty string in text element#186onizet merged 1 commit intoonizet:devfrom
onizet merged 1 commit intoonizet:devfrom
Conversation
|
Owner
|
This is an amazing PR, simple but efficient! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



I had an error while parsing some (admittedly wrong) html, like the following (I reduced to a minimal example)
<span> <div> <br /> <div> <span>Texte</span> </div> </div> </span>The error was :
The submitted code fixed the issue without causing any apparent regression, but I must confess I don't have enough understanding of the internals to assure the modification is needed. I leave that to the appreciation of the reviewer. I figured that, as long as we access the string by index, we should check that it is not empty. My doubts are about what to do if the string is empty.