Skip to content

fix: PhrasingElementExpression.cs - check empty string in text element #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onizet merged 1 commit into from
Jan 20, 2025
Merged

fix: PhrasingElementExpression.cs - check empty string in text element #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Html2OpenXml/Expressions/PhrasingElementExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright (C) Olivier Nizet https://github.com/onizet/html2openxml - All Rights Reserved
/* Copyright (C) Olivier Nizet https://github.com/onizet/html2openxml - All Rights Reserved
*
* This source is subject to the Microsoft Permissive License.
* Please see the License.txt file for more information.
Expand Down Expand Up @@ -208,7 +208,7 @@ protected static IEnumerable<OpenXmlElement> CombineRuns(IEnumerable<OpenXmlElem
// run can be also a hyperlink
textElement ??= run.GetFirstChild<Run>()?.GetFirstChild<Text>();

if (textElement != null) // could be null when <br/>
if (textElement != null && !string.IsNullOrEmpty(textElement.Text)) // could be null when <br/>
{
var text = textElement.Text;
// we know that the text cannot be empty because we skip them in TextExpression
Expand All @@ -225,4 +225,4 @@ protected static IEnumerable<OpenXmlElement> CombineRuns(IEnumerable<OpenXmlElem
yield return run;
}
}
}
}