Fix: map attribute for properties that contain a mix of string and URIs #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atype-dsl Feature: add property data type dsl
…ators Refactor: resources validators
…es to :show_languages: true
Feature: Refactor and fix the Language filter method
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
…-filters Fix: order by an attribute that is already filtered
…ion-empty Fix: pagination with order_by & filter that returns empty pages for 4store
…ion-empty Fix: optimize the pagination query to not re-do the filters and order patterns in the include query
Conflicts: lib/goo/base/resource.rb lib/goo/sparql/mixins/solution_lang_filter.rb lib/goo/sparql/query_builder.rb lib/goo/sparql/solutions_mapper.rb
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 86.13% 85.91% -0.22%
==========================================
Files 37 37
Lines 2668 2669 +1
==========================================
- Hits 2298 2293 -5
- Misses 370 376 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
map_atrrbiutein the case of an attribute is mapped to properties that can be strings or URIs, for example, this:Assuming in this case, the URIs values as with no language.