Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix processing of network_events in tor test #80

Closed
hellais opened this issue Jul 30, 2024 · 2 comments
Closed

Fix processing of network_events in tor test #80

hellais opened this issue Jul 30, 2024 · 2 comments
Assignees
@hellais
Labels
bug Something isn't working funder/otffoss2023-2024 priority/medium

Comments

@hellais
Copy link
Member

hellais commented Jul 30, 2024

Since the changes were made to support web_connectivity 0.5 it looks like a regression was introduced affecting the parsing of tor related network events.

Specifically the stack trace is as follows:

Traceback (most recent call last):
  File "/home/art/repos/ooni/data/oonipipeline/src/oonipipeline/temporal/activities/observations.py", line 107, in make_observations_for_file_entry_batch
    obs_tuple = measurement_to_observations(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/art/repos/ooni/data/oonipipeline/src/oonipipeline/transforms/observations.py", line 66, in measurement_to_observations
    return transformer.make_observations(msmt)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/art/repos/ooni/data/oonipipeline/src/oonipipeline/transforms/nettests/tor.py", line 18, in make_observations
    tls_observations = self.make_tls_observations(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/art/repos/ooni/data/oonipipeline/src/oonipipeline/transforms/measurement_transformer.py", line 835, in make_tls_observations
    measurement_to_tls_observation(
  File "/home/art/repos/ooni/data/oonipipeline/src/oonipipeline/transforms/measurement_transformer.py", line 436, in measurement_to_tls_observation
    if tls_network_events[0].address:
       ~~~~~~~~~~~~~~~~~~^^^

A sample measurement affected by the bug is this one: 20240710234111.216894_RU_tor_2b7326ed5c0bd30d
@hellais
Copy link
Member Author

hellais commented Jul 30, 2024

This isn't just affecting the tor test, it's also other measurements

hellais added a commit that referenced this issue Jul 30, 2024
@hellais
Simplify and fix finding network events by transaction_id
63c7c6c 
Fixes: #80
@hellais hellais mentioned this issue Jul 30, 2024
Merged
hellais added a commit that referenced this issue Aug 1, 2024
@hellais
Add support for temporal cloud (#79)
26db0be 
Changes:
* Major changes to how the CLI works where instead of `mk*` commands we
have `schedule` and `backfill` commands
* Simplify logic for processing tls handshakes by transaction ID.

This fixes:
* #78
* #80

As part of this I am doing also a bit of refactoring of the temporal
related code to make this easier.
@hellais hellais self-assigned this Aug 19, 2024
@hellais
Copy link
Member Author

hellais commented Aug 19, 2024

This was fixed by: 63c7c6c

@hellais hellais closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellais hellais

Labels
bug Something isn't working funder/otffoss2023-2024 priority/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellais