Add support for temporal cloud #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 77.41% 82.08% +4.66%
==========================================
Files 32 75 +43
Lines 1913 6295 +4382
==========================================
+ Hits 1481 5167 +3686
- Misses 432 1128 +696
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is needed for temporal cloud
|
The tests are green and I am already running this on the data.ooni.org host. I am going to proceed with merging it. (the red is only the codecov complaining, but the pieces of impacted code are really hard to test, so I am tabling this for the moment) |
hellais
added a commit
that referenced
this pull request
Aug 30, 2024
* v5.0.0-rc.0: Add simple redirector Tidy up the layout of the analysis viewer Add an observations viewer Get rid of all the dataviz that isn't the analysis visualizer Release/5.0.0 alpha3 (#81) Offset analysis schedule by 6 hours Add support for temporal cloud (#79) fix: support for sorting network_events using transaction_id (#51) Optimize performance of table writers and refactor table model (#74) Improvements related to deployment (#69) Add .codecov file Update jsonl sync example Setup workflow to publish ooni data docs (#73) OONI Pipeline v5 alpha (#64) Fix codecov (#62) Temporal workflows (#61) OONI Data, OONI Pipeline split (#60) Add support for caching netinfodb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
mk*commands we havescheduleandbackfillcommandsThis fixes:
As part of this I am doing also a bit of refactoring of the temporal related code to make this easier.