Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OONI Pipeline v5 alpha #64

Merged
merged 65 commits into from
Apr 30, 2024
Merged

OONI Pipeline v5 alpha #64

merged 65 commits into from
Apr 30, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Apr 24, 2024

Work towards a v5 alpha tag of the OONI Pipeline

Features:

  • Add docker-compose based setup
  • Major improvements to the oonipipeline CLI working towards CLI stability
  • Usage documentation for oonipipeline

Changes:

  • Compute the final_ok value based on min(final_ok)
  • Major refactoring of workflows to better follow best practices of temporal
  • Add scheduling support for observations workflow
  • Add support for submitting open telemetry tracing metrics

Bug fixes:

  • Set the ok.tcp LoNI value for TCP in the event of it being OK

Improvements:

  • More extensive testing of the analysis

Closes: #66

@hellais
Copy link
Member Author

hellais commented Apr 24, 2024

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 86.46465% with 134 lines in your changes missing coverage. Please review.

Project coverage is 84.10%. Comparing base (d5bcbfc) to head (16ebc35).
Report is 10 commits behind head on main.

Files Patch % Lines
oonipipeline/tests/test_workflows.py 72.90% 42 Missing ⚠️
oonipipeline/src/oonipipeline/cli/commands.py 68.85% 38 Missing ⚠️
...c/oonipipeline/temporal/activities/observations.py 85.43% 15 Missing ⚠️
...onipipeline/src/oonipipeline/temporal/workflows.py 91.07% 15 Missing ⚠️
...e/src/oonipipeline/temporal/activities/analysis.py 88.69% 13 Missing ⚠️
oonipipeline/tests/test_analysis.py 96.12% 6 Missing ⚠️
oonipipeline/src/oonipipeline/db/connections.py 66.66% 2 Missing ⚠️
...onipipeline/analysis/website_experiment_results.py 93.75% 1 Missing ⚠️
.../oonipipeline/temporal/activities/ground_truths.py 97.14% 1 Missing ⚠️
oonipipeline/src/oonipipeline/temporal/workers.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #64       +/-   ##
===========================================
+ Coverage   72.43%   84.10%   +11.66%     
===========================================
  Files          73       74        +1     
  Lines        5613     5890      +277     
===========================================
+ Hits         4066     4954      +888     
+ Misses       1547      936      -611     
Flag Coverage Δ
oonidata 77.44% <ø> (ø)
oonipipeline 87.26% <86.46%> (+17.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellais hellais mentioned this pull request Apr 25, 2024
13 tasks
@hellais hellais merged commit 2c88749 into main Apr 30, 2024
8 checks passed
@hellais hellais deleted the oonipipeline-v5alpha branch April 30, 2024 15:31
@hellais hellais restored the oonipipeline-v5alpha branch August 23, 2024 12:32
@hellais hellais deleted the oonipipeline-v5alpha branch August 24, 2024 08:06
hellais added a commit that referenced this pull request Aug 30, 2024
* v5.0.0-rc.0:
  Add simple redirector
  Tidy up the layout of the analysis viewer
  Add an observations viewer
  Get rid of all the dataviz that isn't the analysis visualizer
  Release/5.0.0 alpha3 (#81)
  Offset analysis schedule by 6 hours
  Add support for temporal cloud (#79)
  fix: support for sorting network_events using transaction_id (#51)
  Optimize performance of table writers and refactor table model (#74)
  Improvements related to deployment (#69)
  Add .codecov file
  Update jsonl sync example
  Setup workflow to publish ooni data docs (#73)
  OONI Pipeline v5 alpha (#64)
  Fix codecov (#62)
  Temporal workflows (#61)
  OONI Data, OONI Pipeline split (#60)
  Add support for caching netinfodb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag OONI Pipeline v5 alpha
1 participant