fix(netemx): address issues with quic-go/quic-go #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff fixes ooni/probe#2527. The comment I originally wrote in the code to explain the issue read: > I am wondering whether I am not fully understanding how quic-go/quic-go works. It turns out this comment was true. I was assuming http3.Server was closing the listener, however, that was not the case. I noticed this issue when reading again netemx/qaenv.go. So, it all boiled down to PEBCAK 😬.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff fixes ooni/probe#2527. The comment I originally wrote in the code to explain the issue read: > I am wondering whether I am not fully understanding how quic-go/quic-go works. It turns out this comment was true. I was assuming http3.Server was closing the listener, however, that was not the case. I noticed this issue when reading again netemx/qaenv.go. So, it all boiled down to PEBCAK 😬. ## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2527 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff fixes ooni/probe#2527.
The comment I originally wrote in the code to explain the issue read:
It turns out this comment was true. I was assuming http3.Server was closing the listener, however, that was not the case.
I noticed this issue when reading again netemx/qaenv.go.
So, it all boiled down to PEBCAK 😬.
Checklist