Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netemx): address issues with quic-go/quic-go #1228

Merged
merged 2 commits into from
Sep 4, 2023
Merged

fix(netemx): address issues with quic-go/quic-go #1228

merged 2 commits into from
Sep 4, 2023

Commits on Sep 4, 2023

  1. fix(netemx): address issues with quic-go/quic-go 

    This diff fixes ooni/probe#2527.

The comment I originally wrote in the code to explain the issue read:

> I am wondering whether I am not fully understanding how quic-go/quic-go works.

It turns out this comment was true. I was assuming http3.Server was closing
the listener, however, that was not the case.

I noticed this issue when reading again netemx/qaenv.go.

So, it all boiled down to PEBCAK 😬.
    @bassosimone
    bassosimone committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    5ba610a View commit details
    Browse the repository at this point in the history

  2. x

    @bassosimone
    bassosimone committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    5a7e62e View commit details
    Browse the repository at this point in the history